Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(rust): Add streaming groupby for reductions #19291

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

orlp
Copy link
Collaborator

@orlp orlp commented Oct 17, 2024

No description provided.

@github-actions github-actions bot added internal An internal refactor or improvement rust Related to Rust Polars labels Oct 17, 2024
@orlp orlp marked this pull request as ready for review October 18, 2024 13:31
Copy link

codecov bot commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 28.47100% with 407 lines in your changes missing coverage. Please review.

Project coverage is 79.89%. Comparing base (dae6cd9) to head (9ff7a20).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-stream/src/nodes/group_by.rs 0.00% 138 Missing ⚠️
crates/polars-expr/src/groups/row_encoded.rs 0.00% 134 Missing ⚠️
crates/polars-core/src/series/mod.rs 0.00% 46 Missing ⚠️
crates/polars-stream/src/physical_plan/lower_ir.rs 0.00% 25 Missing ⚠️
crates/polars-core/src/datatypes/dtype.rs 0.00% 17 Missing ⚠️
...-core/src/chunked_array/logical/categorical/mod.rs 0.00% 10 Missing ⚠️
crates/polars-expr/src/groups/mod.rs 0.00% 10 Missing ⚠️
...es/polars-core/src/chunked_array/ops/row_encode.rs 94.54% 9 Missing ⚠️
crates/polars-core/src/schema.rs 0.00% 5 Missing ⚠️
crates/polars-expr/src/reduce/convert.rs 0.00% 2 Missing ⚠️
... and 9 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #19291      +/-   ##
==========================================
- Coverage   80.00%   79.89%   -0.12%     
==========================================
  Files        1528     1532       +4     
  Lines      209850   210239     +389     
  Branches     2419     2419              
==========================================
+ Hits       167894   167960      +66     
- Misses      41405    41728     +323     
  Partials      551      551              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal An internal refactor or improvement rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant