fix(python): Make the SQLAlchemy connection check more robust #19270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-beedie
requested review from
ritchie46,
c-peters,
MarcoGorelli and
reswqa
as code owners
alexander-beedie
force-pushed
the
sqlalchemy-connection-check
branch
from
e7ee424
to
4740691
Compare
alexander-beedie
force-pushed
the
sqlalchemy-connection-check
branch
from
4740691
to
7f14e4f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #19270 +/- ##
==========================================
- Coverage 80.03% 79.97% -0.07%
==========================================
Files 1528 1529 +1
Lines 209657 209816 +159
Branches 2416 2416
==========================================
Hits 167791 167791
- Misses 41317 41476 +159
Partials 549 549 ☔ View full report in Codecov by Sentry. |
ritchie46
approved these changes
Oct 17, 2024
|
Thanks for the quick turnaround. And thanks for providing this optimized path for database I/O. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small follow-up to #19255.
Fixes some docstring comments, and improves the SQLAlchemy object/connection check.
(FYI: @daniel-thom, this addresses your issue yesterday on the DuckDB fix).