Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Do not check dtypes of non-projected columns for parquet #19254

Merged
merged 2 commits into from
Oct 16, 2024

Conversation

nameexhaustion
Copy link
Collaborator

Fixes #19249

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Oct 16, 2024
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 76.92308% with 3 lines in your changes missing coverage. Please review.

Project coverage is 80.03%. Comparing base (9376ce3) to head (e3820bb).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-io/src/parquet/read/reader.rs 83.33% 2 Missing ⚠️
...-stream/src/nodes/parquet_source/metadata_fetch.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #19254      +/-   ##
==========================================
+ Coverage   80.00%   80.03%   +0.02%     
==========================================
  Files        1527     1528       +1     
  Lines      209211   209572     +361     
  Branches     2415     2415              
==========================================
+ Hits       167377   167725     +348     
- Misses      41286    41299      +13     
  Partials      548      548              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit d91b99c into pola-rs:main Oct 16, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

allow_missing_columns seems to break pushdown of column select in scan_parquet
2 participants