feat: Expose LTS CPU in show_versions() #19193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alonme
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli and
reswqa
as code owners
alonme
commented
Oct 11, 2024
| @@ -12,4 +12,5 @@ def test_show_versions(capsys: Any) -> None: | |||
| out, _ = capsys.readouterr() | |||
| assert "Python" in out | |||
| assert "Polars" in out | |||
| assert "LTS CPU" in out | |||
There was a problem hiding this comment.
There are some other fields that we can test for - should i add those too?
There was a problem hiding this comment.
What were you thinking about testing? Either way, not in this PR.
There was a problem hiding this comment.
Version info Index type and Platform
alonme
commented
Oct 11, 2024
| @@ -137,7 +137,6 @@ jobs: | |||
| if: matrix.architecture == 'x86-64' | |||
| env: | |||
| IS_LTS_CPU: ${{ matrix.package == 'polars-lts-cpu' }} | |||
| IS_MACOS: ${{ matrix.os == 'macos-13' }} | |||
alonme
changed the title
github-actions
bot
added
enhancement
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #19193 +/- ##
=======================================
Coverage 79.64% 79.65%
=======================================
Files 1532 1532
Lines 209131 209135 +4
Branches 2416 2416
=======================================
+ Hits 166570 166592 +22
+ Misses 42015 41997 -18
Partials 546 546 ☔ View full report in Codecov by Sentry. |
orlp
approved these changes
Oct 11, 2024
ritchie46
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #19109
This PR both exposes LTS CPU in
show_versions()and fixes an issue in the release workflow where the_POLARS_LTS_CPUwasn't set correctly.The LTS CPU was originally supposed to be taken into account by
check_cpu_flagshowever, because of the mentioned issue it was practically always False and so we can deem it safe to remove it from that check