Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Series::{first, last, approx_n_unique} #19093

Merged
merged 4 commits into from
Oct 4, 2024

Conversation

coastalwhite
Copy link
Collaborator

This now implements the aggregations that were already available as DataFrame expressions for Series as well.

Fixes #19073.

@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars labels Oct 4, 2024
Copy link

codecov bot commented Oct 4, 2024

Codecov Report

Attention: Patch coverage is 56.33803% with 31 lines in your changes missing coverage. Please review.

Project coverage is 79.76%. Comparing base (f55658b) to head (8fa41ab).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-core/src/series/series_trait.rs 63.15% 7 Missing ⚠️
crates/polars-python/src/series/aggregation.rs 46.15% 7 Missing ⚠️
crates/polars-core/src/frame/column/mod.rs 50.00% 4 Missing ⚠️
...s/polars-core/src/series/implementations/binary.rs 0.00% 3 Missing ⚠️
.../polars-core/src/series/implementations/boolean.rs 0.00% 3 Missing ⚠️
...s/polars-core/src/series/implementations/floats.rs 0.00% 3 Missing ⚠️
...s/polars-core/src/series/implementations/string.rs 0.00% 3 Missing ⚠️
py-polars/polars/series/series.py 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #19093      +/-   ##
==========================================
- Coverage   79.77%   79.76%   -0.01%     
==========================================
  Files        1531     1531              
  Lines      208529   208561      +32     
  Branches     2913     2913              
==========================================
+ Hits       166347   166368      +21     
- Misses      41631    41642      +11     
  Partials      551      551              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@orlp orlp merged commit baa65b8 into pola-rs:main Oct 4, 2024
26 checks passed
@coastalwhite coastalwhite deleted the feat/series-aggs branch October 4, 2024 11:39
@ritchie46
Copy link
Member

This one still needs docs entries in the python reference guide. @coastalwhite

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some aggregation methods are missing from pl.Series
3 participants