fix: Implement to_arrow functionality properly for Arrays #19077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siddharth-vi
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli,
reswqa and
orlp
as code owners
github-actions
bot
added
fix
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #19077 +/- ##
==========================================
- Coverage 79.84% 79.76% -0.09%
==========================================
Files 1525 1531 +6
Lines 207823 208522 +699
Branches 2913 2913
==========================================
+ Hits 165946 166332 +386
- Misses 41326 41639 +313
Partials 551 551 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18810
Currently there is no special branch to handle to_arrow conversion for Arrays, due to which Array of logical types are not converted properly. This fix implements this branch, similar to the one for Lists.
While converting to pickle, to_arrow is used, hence converting to arrow properly also fixes the above issue.