fix: Wrong result on when().then().otherwise() on struct when both result are broadcast
#19000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barak1412
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli,
reswqa and
orlp
as code owners
barak1412
changed the title
when().then().otherwise() on struct when both result are broadcastwhen().then().otherwise() on struct when both result are broadcast
github-actions
bot
added
fix
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #19000 +/- ##
=======================================
Coverage 79.88% 79.88%
=======================================
Files 1524 1524
Lines 207634 207641 +7
Branches 2904 2904
=======================================
+ Hits 165873 165880 +7
Misses 41214 41214
Partials 547 547 ☔ View full report in Codecov by Sentry. |
|
Can you fix the mypy issues? |
ritchie46
changed the title
when().then().otherwise() on struct when both result are broadcastwhen().then().otherwise() on struct when both result are broadcast
|
Sorry, saw your message little late. In the evening, I plan to rebase my other PR and push again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #18969, with different path.