Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Properly implement AnyValue::Binary into_py #18960

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

coastalwhite
Copy link
Collaborator

Fixes #18953.

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Sep 27, 2024
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 79.84%. Comparing base (a7845c4) to head (aa18b8c).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-python/src/conversion/any_value.rs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #18960   +/-   ##
=======================================
  Coverage   79.83%   79.84%           
=======================================
  Files        1522     1523    +1     
  Lines      207264   207297   +33     
  Branches     2906     2906           
=======================================
+ Hits       165479   165518   +39     
+ Misses      41237    41231    -6     
  Partials      548      548           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit cafc163 into pola-rs:main Sep 27, 2024
22 checks passed
@coastalwhite coastalwhite deleted the fixes/binary-av-into-py branch September 27, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

to_dicts with binary column yields list[int] instead of bytes.
2 participants