-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Return the truth values of ne_missing
and eq_missing
operations for struct instead of null
#18930
Merged
ritchie46
merged 9 commits into
pola-rs:main
from
barak1412:fix_struct_missing_comparision_ops
Sep 29, 2024
Merged
fix: Return the truth values of ne_missing
and eq_missing
operations for struct instead of null
#18930
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
d0b0385
first working version with test
barak1412 434b124
second trial
barak1412 e90a30f
third trial
barak1412 7ddee06
debug
barak1412 bc51878
working version
barak1412 87559e6
Merge branch 'main' of https://github.com/barak1412/polars into fix_s…
barak1412 9b45bbd
Merge branch 'main' of https://github.com/barak1412/polars into fix_s…
barak1412 9d0e073
cr fix
barak1412 b26829f
cr fix
barak1412 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, this is not what this PR is trying to solve, but we made a policy that nested equality is always eq_missing. Maybe, this should changed here too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sense, thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think not all types support
eq_missing
, so the code reachespanic
.Maybe it is better to get fixed in separate PR?