perf: Cache register plugin function #18860
Conversation
github-actions
bot
added
performance
| @@ -111,6 +112,7 @@ def _serialize_kwargs(kwargs: dict[str, Any] | None) -> bytes: | |||
| return pickle.dumps(kwargs, protocol=5) | |||
|
|
|||
|
|
|||
| @lru_cache(maxsize=16) | |||
There was a problem hiding this comment.
a large number of pathlib objects can be heavy to cache: psf/black#1950. so i think it's good to set a maxsize
I think it's very unlikely that anyone would be using more than 16 plugins in the same project anyway..
There was a problem hiding this comment.
a large number of pathlib objects can be heavy to cache: psf/black#1950. so i think it's good to set a maxsize
I think it's very unlikely that anyone would be using more than 16 plugins in the same project anyway..
Does 16 mean 16 different plugin functions or 16 distinct plugins?
There was a problem hiding this comment.
NVM, should be 16 plugin packages..
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18860 +/- ##
=======================================
Coverage 79.87% 79.88%
=======================================
Files 1519 1519
Lines 205839 205841 +2
Branches 2898 2899 +1
=======================================
+ Hits 164416 164438 +22
+ Misses 40875 40855 -20
Partials 548 548 ☔ View full report in Codecov by Sentry. |
MarcoGorelli
requested review from
ritchie46,
c-peters,
alexander-beedie and
reswqa
as code owners
closes #18857
Can confirm that this resolves the issue
before:
after: