Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Address spurious hypothesis test failure #18434

Merged
merged 1 commit into from
Aug 28, 2024
Merged

test: Address spurious hypothesis test failure #18434

merged 1 commit into from
Aug 28, 2024

Conversation

MarcoGorelli
Copy link
Collaborator

@MarcoGorelli MarcoGorelli commented Aug 28, 2024 •
edited
Loading

@MarcoGorelli MarcoGorelli changed the title test: address spurious hypothesis test failure test: Address spurious hypothesis test failure Aug 28, 2024
@github-actions github-actions bot added title needs formatting internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars and removed title needs formatting labels Aug 28, 2024
@MarcoGorelli MarcoGorelli marked this pull request as ready for review August 28, 2024 14:10
@ritchie46 ritchie46 merged commit a5b441a into pola-rs:main Aug 28, 2024
15 of 16 checks passed
@codecov Codecov
Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.92%. Comparing base (fb38919) to head (d5bc8ca).
Report is 7 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #18434   +/-   ##
=======================================
  Coverage   79.91%   79.92%           
=======================================
  Files        1495     1496    +1     
  Lines      200261   200190   -71     
  Branches     2867     2867           
=======================================
- Hits       160033   159992   -41     
+ Misses      39682    39652   -30     
  Partials      546      546

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

r-brink pushed a commit to r-brink/polars that referenced this pull request Aug 29, 2024
@MarcoGorelli @r-brink
test: Address spurious hypothesis test failure (pola-rs#18434)
0098343
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritchie46 ritchie46 Awaiting requested review from ritchie46 ritchie46 is a code owner

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

@alexander-beedie alexander-beedie Awaiting requested review from alexander-beedie alexander-beedie is a code owner

@reswqa reswqa Awaiting requested review from reswqa reswqa is a code owner

Assignees
No one assigned
Labels
internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pl.cum_count() with no arguments does not work as documented
2 participants
@MarcoGorelli @ritchie46