-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Parquet several smaller issues #18325
fix: Parquet several smaller issues #18325
Conversation
@@ -202,6 +202,17 @@ pub fn columns_to_iter_recursive( | |||
)? | |||
.collect_n(filter)? | |||
}, | |||
Binary | Utf8 => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't support those types. I think we directly use BinviewDecoder
here if we can.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will leave this for this PR. But we should be able to remove the code that generates (Large)Utf8
, (LargeBinary)
in favor of BinaryView
.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #18325 +/- ##
==========================================
+ Coverage 80.35% 80.50% +0.14%
==========================================
Files 1501 1501
Lines 199214 199420 +206
Branches 2837 2837
==========================================
+ Hits 160087 160545 +458
+ Misses 38599 38349 -250
+ Partials 528 526 -2 ☔ View full report in Codecov by Sentry. |
This fixes several small parquet problems.
I would recommend reviewing this PR commit by commit.
Fixes #18304.
Fixes #18303.