Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Don't rechunk aligned chunks in owned_binary_chunk_align #18314

Merged
merged 1 commit into from
Aug 22, 2024
Merged

Conversation

ritchie46
Copy link
Member

We can follow up with a alignment strategy that never rechunks. This fixes the completely unneeded case.

@github-actions github-actions bot added performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars labels Aug 22, 2024
Copy link

codecov bot commented Aug 22, 2024

Codecov Report

Attention: Patch coverage is 7.14286% with 13 lines in your changes missing coverage. Please review.

Project coverage is 80.33%. Comparing base (6c4835e) to head (f4bd051).
Report is 22 commits behind head on main.

Files Patch % Lines
crates/polars-core/src/utils/mod.rs 7.14% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18314      +/-   ##
==========================================
- Coverage   80.35%   80.33%   -0.02%     
==========================================
  Files        1501     1501              
  Lines      199222   199236      +14     
  Branches     2837     2837              
==========================================
- Hits       160083   160062      -21     
- Misses      38613    38648      +35     
  Partials      526      526              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit a601ccf into main Aug 22, 2024
21 checks passed
@ritchie46 ritchie46 deleted the rechunk branch August 22, 2024 14:03
@c-peters c-peters added the accepted Ready for implementation label Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants