Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Skip parquet page when unneeded #18192

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

coastalwhite
Copy link
Collaborator

No description provided.

@github-actions github-actions bot added performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars labels Aug 14, 2024
@ritchie46 ritchie46 merged commit 92ccde6 into pola-rs:main Aug 14, 2024
20 checks passed
Copy link

codecov bot commented Aug 14, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.33%. Comparing base (21f02a6) to head (a79c514).
Report is 39 commits behind head on main.

Files Patch % Lines
...rs-parquet/src/arrow/read/deserialize/utils/mod.rs 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18192      +/-   ##
==========================================
+ Coverage   80.31%   80.33%   +0.01%     
==========================================
  Files        1498     1500       +2     
  Lines      198654   198836     +182     
  Branches     2831     2833       +2     
==========================================
+ Hits       159555   159728     +173     
- Misses      38572    38581       +9     
  Partials      527      527              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coastalwhite coastalwhite deleted the parquet-skip-whole-pages branch August 15, 2024 06:05
@c-peters c-peters added the accepted Ready for implementation label Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants