Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(python): Make expensive selector expansion lazy #18118

Merged
merged 10 commits into from
Aug 11, 2024
Merged

perf(python): Make expensive selector expansion lazy #18118

merged 10 commits into from
Aug 11, 2024

Conversation

ritchie46
Copy link
Member

@ritchie46 ritchie46 commented Aug 9, 2024

Will do a bunch of them.

@github-actions github-actions bot added performance Performance issues or improvements python Related to Python Polars labels Aug 9, 2024
Copy link

codecov bot commented Aug 9, 2024

Codecov Report

Attention: Patch coverage is 78.60697% with 43 lines in your changes missing coverage. Please review.

Project coverage is 80.33%. Comparing base (9dd9569) to head (170fbb3).
Report is 1 commits behind head on main.

Files Patch % Lines
py-polars/src/lazyframe/visitor/nodes.rs 0.00% 15 Missing ⚠️
crates/polars-plan/src/plans/functions/mod.rs 52.38% 10 Missing ⚠️
crates/polars-plan/src/plans/functions/dsl.rs 84.78% 7 Missing ⚠️
crates/polars-plan/src/plans/conversion/mod.rs 0.00% 5 Missing ⚠️
py-polars/polars/lazyframe/frame.py 80.00% 1 Missing and 1 partial ⚠️
...rs-lazy/src/physical_plan/streaming/convert_alp.rs 0.00% 1 Missing ⚠️
crates/polars-plan/src/client/check.rs 50.00% 1 Missing ⚠️
crates/polars-plan/src/dsl/options.rs 0.00% 1 Missing ⚠️
crates/polars-plan/src/plans/builder_ir.rs 75.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #18118   +/-   ##
=======================================
  Coverage   80.33%   80.33%           
=======================================
  Files        1496     1496           
  Lines      197685   197746   +61     
  Branches     2821     2822    +1     
=======================================
+ Hits       158806   158859   +53     
- Misses      38358    38365    +7     
- Partials      521      522    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 requested a review from wence- as a code owner August 10, 2024 07:58
@ritchie46
Copy link
Member Author

ritchie46 commented Aug 11, 2024

@alexander-beedie I got almost all of them except for the one in lf.cast. Maybe we can translate the cast selectors to a with_columns(<selector>.cast()). That will automatically be resolved in the rust side.

@ritchie46 ritchie46 merged commit afd93b2 into main Aug 11, 2024
25 checks passed
@ritchie46 ritchie46 deleted the selector branch August 11, 2024 08:11
@c-peters c-peters added the accepted Ready for implementation label Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation performance Performance issues or improvements python Related to Python Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants