-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Panic reading multiple CSV files from cloud #18056
Conversation
@@ -95,7 +95,7 @@ pub fn init_entries_from_uri_list( | |||
let cloud_path = object_path_from_str(&prefix)?; | |||
|
|||
let object_store = | |||
object_stores[std::cmp::min(i, object_stores.len())].clone(); | |||
object_stores[std::cmp::min(i, object_stores.len() - 1)].clone(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
silly mistake 😅
we unfortunately can't add this to our test suite because it needs a real bucket
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happens to the best of us 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick fix!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nameexhaustion Would it make sense to add a test which uses Azurite (using docker) or similar to test reading from "the cloud"? https://github.com/Azure/Azurite
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18056 +/- ##
==========================================
- Coverage 80.39% 80.37% -0.02%
==========================================
Files 1496 1496
Lines 197480 197480
Branches 2820 2820
==========================================
- Hits 158764 158728 -36
- Misses 38194 38230 +36
Partials 522 522 ☔ View full report in Codecov by Sentry. |
Fixes #18053