perf: Remove temporary allocations in Parquet #18013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes more than 50% of the temporary allocations in the Parquet readers. The only temporary allocations left are in the Thrift definitions and the `polars_io` code.
github-actions
bot
added
performance
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #18013 +/- ##
==========================================
- Coverage 80.49% 80.47% -0.02%
==========================================
Files 1496 1496
Lines 196786 196806 +20
Branches 2817 2817
==========================================
- Hits 158407 158389 -18
- Misses 37858 37896 +38
Partials 521 521 ☔ View full report in Codecov by Sentry. |
ritchie46
reviewed
Aug 4, 2024
| @@ -201,10 +201,11 @@ impl<'a> BinaryStateTranslation<'a> { | |||
| } | |||
|
|
|||
| pub(crate) fn deserialize_plain(values: &[u8], num_values: usize) -> BinaryDict { | |||
| let all = BinaryIter::new(values, num_values).collect::<Vec<_>>(); | |||
ritchie46
approved these changes
Aug 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes more than 50% of the temporary allocations in the Parquet readers. The only temporary allocations left are in the Thrift definitions and the
polars_iocode.