Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(python): Default to None in pycapsule interface export #17922

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

kylebarron
Copy link
Contributor

Closes #17921

@WillAyd
Copy link

WillAyd commented Jul 29, 2024

Awesome thanks @kylebarron for the quick turnaround

Copy link

codecov bot commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.50%. Comparing base (5fc791c) to head (6d13cca).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17922      +/-   ##
==========================================
+ Coverage   80.49%   80.50%   +0.01%     
==========================================
  Files        1493     1493              
  Lines      196477   196477              
  Branches     2813     2813              
==========================================
+ Hits       158155   158180      +25     
+ Misses      37801    37776      -25     
  Partials      521      521              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46
Copy link
Member

Thanks for the report @WillAyd, and thank you @kylebarron for the quick fix.

@ritchie46 ritchie46 merged commit f7cac6b into pola-rs:main Jul 29, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Arrow PyCapsule TypeError: __arrow_c_stream__() missing 1 required positional argument: 'requested_schema'
3 participants