Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(python): Fix return type hint for LazyFrame sink methods #17698

Merged
merged 1 commit into from
Jul 18, 2024
Merged

fix(python): Fix return type hint for LazyFrame sink methods #17698

merged 1 commit into from
Jul 18, 2024

Conversation

eitsupi
Copy link
Contributor

@eitsupi eitsupi commented Jul 18, 2024

No description provided.

@eitsupi eitsupi changed the title chore(python): fix type hint chore(python): Fix type hint of sink_* methods Jul 18, 2024
@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars and removed title needs formatting labels Jul 18, 2024
@eitsupi eitsupi changed the title chore(python): Fix type hint of sink_* methods chore(python): Fix type hint of LazyFrame.sink_* methods Jul 18, 2024
@alexander-beedie alexander-beedie changed the title chore(python): Fix type hint of LazyFrame.sink_* methods fix(python): Fix return type hint for LazyFrame sink methods Jul 18, 2024
ritchie46
ritchie46 approved these changes Jul 18, 2024
View reviewed changes
Copy link
Member

@ritchie46 ritchie46 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yeah.. Good catch

@ritchie46 ritchie46 merged commit 965ce85 into pola-rs:main Jul 18, 2024
15 of 18 checks passed
@eitsupi eitsupi deleted the fix-hint branch July 18, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritchie46 ritchie46 ritchie46 approved these changes

@stinodego stinodego Awaiting requested review from stinodego

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

@alexander-beedie alexander-beedie Awaiting requested review from alexander-beedie alexander-beedie is a code owner

@MarcoGorelli MarcoGorelli Awaiting requested review from MarcoGorelli MarcoGorelli is a code owner

@reswqa reswqa Awaiting requested review from reswqa reswqa is a code owner

Assignees
No one assigned
Labels
fix Bug fix internal An internal refactor or improvement python Related to Python Polars title needs formatting
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eitsupi @ritchie46