fix: Bitmap collect into safety #17588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coastalwhite
requested review from
ritchie46,
stinodego,
c-peters,
alexander-beedie,
MarcoGorelli,
reswqa and
orlp
as code owners
github-actions
bot
added
fix
Fixes pola-rs#17579. This now properly checks the safety within the `BitmapIter::collect_n_into`. This was sloppy on my end and it is now much better tested.
coastalwhite
force-pushed
the
fix-bitmap-collect-17579
branch
from
eed22cc
to
1456f03
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17588 +/- ##
=======================================
Coverage 80.44% 80.45%
=======================================
Files 1484 1484
Lines 195532 195594 +62
Branches 2778 2778
=======================================
+ Hits 157299 157359 +60
- Misses 37721 37723 +2
Partials 512 512 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17579.
This fixes a regression in #17542. This now properly checks the safety within the
BitmapIter::collect_n_into. This was sloppy on my end and it is now much better tested.