Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Add fastpath for when rounding by single constant durations #17580

Merged
merged 4 commits into from
Jul 13, 2024

Conversation

MarcoGorelli
Copy link
Collaborator

@MarcoGorelli MarcoGorelli commented Jul 11, 2024

Combines:

and implements them for round. I've included a hypothesis test right away to check this doesn't introduce regressions

I'll pick https://github.com/pola-rs/polars/pull/12597/files up again after this one, let's try to get it across the line


drive-by: moving some .dt.round tests to test_round.py

Copy link

codecov bot commented Jul 11, 2024

Codecov Report

Attention: Patch coverage is 94.80519% with 4 lines in your changes missing coverage. Please review.

Project coverage is 80.45%. Comparing base (b33d3f1) to head (3a2b84f).
Report is 13 commits behind head on main.

Files Patch % Lines
crates/polars-time/src/round.rs 94.80% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17580      +/-   ##
==========================================
- Coverage   80.45%   80.45%   -0.01%     
==========================================
  Files        1484     1484              
  Lines      195324   195388      +64     
  Branches     2778     2778              
==========================================
+ Hits       157149   157191      +42     
- Misses      37663    37685      +22     
  Partials      512      512              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MarcoGorelli MarcoGorelli changed the title perf: add fastpath for when rounding by single constant durations perf: Add fastpath for when rounding by single constant durations Jul 11, 2024
@github-actions github-actions bot added performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars and removed title needs formatting labels Jul 11, 2024
@MarcoGorelli MarcoGorelli marked this pull request as ready for review July 11, 2024 20:09
@ritchie46 ritchie46 merged commit f2fed3b into pola-rs:main Jul 13, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants