Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(python): Fixup "deprecated" directive for DataFrame.melt and LazyFrame.melt #17530

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

MarcoGorelli
Copy link
Collaborator

the deprecation isn't currently rendering

also, drive-by, by parse_version parses a string as a tuple of ints - it would be better to just construct the tuple of ints directly

@MarcoGorelli MarcoGorelli changed the title docs(python): fixup "deprecated" directive for DataFrame.melt and LazyFrame.melt docs(python): Fixup "deprecated" directive for DataFrame.melt and LazyFrame.melt Jul 9, 2024
@github-actions github-actions bot added documentation Improvements or additions to documentation python Related to Python Polars and removed title needs formatting labels Jul 9, 2024
@MarcoGorelli MarcoGorelli marked this pull request as ready for review July 9, 2024 17:17
Copy link

codecov bot commented Jul 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.49%. Comparing base (daf2e49) to head (58155f0).

Files Patch % Lines
py-polars/polars/dataframe/frame.py 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #17530   +/-   ##
=======================================
  Coverage   80.48%   80.49%           
=======================================
  Files        1483     1483           
  Lines      195118   195118           
  Branches     2778     2778           
=======================================
+ Hits       157039   157051   +12     
+ Misses      37568    37556   -12     
  Partials      511      511           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit b33d3f1 into pola-rs:main Jul 11, 2024
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation python Related to Python Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants