Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(python): Make schema picklable #17524

Merged
merged 1 commit into from
Jul 12, 2024
Merged

Conversation

moritzwilksch
Copy link
Contributor

@moritzwilksch moritzwilksch commented Jul 9, 2024

fixes #17523

during unpickling, an instance of Schema is instantiated without passing the schema argument. In this case, we should create an empty Schema instead of erroring.

@moritzwilksch moritzwilksch changed the title fix(python): cannot load pickled schema fix(python): Make schema picklable Jul 9, 2024
@github-actions github-actions bot added fix Bug fix python Related to Python Polars and removed title needs formatting labels Jul 9, 2024
Copy link

codecov bot commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.49%. Comparing base (a5724d6) to head (5d2bb5c).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17524      +/-   ##
==========================================
+ Coverage   80.47%   80.49%   +0.01%     
==========================================
  Files        1482     1483       +1     
  Lines      195119   195119              
  Branches     2778     2778              
==========================================
+ Hits       157026   157052      +26     
+ Misses      37582    37556      -26     
  Partials      511      511              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit a098ed1 into pola-rs:main Jul 12, 2024
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cannot load pickled polars.schema.Schema
2 participants