Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Exclude empty files from directory/glob expansion #17478

Merged
merged 3 commits into from
Jul 8, 2024

Conversation

nameexhaustion
Copy link
Collaborator

Fixes #17362

Empty files/objects are now excluded from both directory and glob expansion.

@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars labels Jul 8, 2024
Copy link

codecov bot commented Jul 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.47%. Comparing base (ad836bd) to head (66e6493).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17478      +/-   ##
==========================================
- Coverage   80.49%   80.47%   -0.03%     
==========================================
  Files        1483     1483              
  Lines      195010   195128     +118     
  Branches     2781     2782       +1     
==========================================
+ Hits       156972   157023      +51     
- Misses      37527    37593      +66     
- Partials      511      512       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Jul 8, 2024

CodSpeed Performance Report

Merging #17478 will not alter performance

Comparing nameexhaustion:expand-empty-file (66e6493) with main (b347717)

Summary

✅ 37 untouched benchmarks

@ritchie46 ritchie46 merged commit 553f30b into pola-rs:main Jul 8, 2024
26 checks passed
@nameexhaustion nameexhaustion deleted the expand-empty-file branch July 8, 2024 12:39
henryharbeck pushed a commit to henryharbeck/polars that referenced this pull request Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when passing directory path of hive-partitioned parquet dataset to scan_parquet
2 participants