Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(rust): chrono's ParseErrorKind is now public #17201

Merged
merged 2 commits into from
Jun 26, 2024

Conversation

IvanIsCoding
Copy link
Contributor

Ref chronotope/chrono#588

This is a minor clean up to address a TODO. The current version of chrono has ParseErrorKind as a public enum. Hence, polars-time no longer needs to define its own enum and use std::mem::transmute to convert between the two types

@github-actions github-actions bot added internal An internal refactor or improvement rust Related to Rust Polars labels Jun 26, 2024
Copy link

codecov bot commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.86%. Comparing base (b8ac923) to head (7b166fa).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17201      +/-   ##
==========================================
+ Coverage   80.82%   80.86%   +0.03%     
==========================================
  Files        1464     1464              
  Lines      192019   192017       -2     
  Branches     2744     2744              
==========================================
+ Hits       155196   155267      +71     
+ Misses      36312    36239      -73     
  Partials      511      511              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ritchie46 ritchie46 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice TODO hunt. 👍

@ritchie46 ritchie46 merged commit cbd194e into pola-rs:main Jun 26, 2024
21 checks passed
alexander-beedie pushed a commit to alexander-beedie/polars that referenced this pull request Jun 26, 2024
alexander-beedie pushed a commit to alexander-beedie/polars that referenced this pull request Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal An internal refactor or improvement rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants