Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement multiply and division for lhs duration #16948

Merged
merged 3 commits into from
Jun 14, 2024
Merged

Conversation

ritchie46
Copy link
Member

@ritchie46 ritchie46 commented Jun 14, 2024

Ensure we get the proper types and raise better errors if not supported.

fixes #16927

@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars labels Jun 14, 2024
Copy link

codspeed-hq bot commented Jun 14, 2024

CodSpeed Performance Report

Merging #16948 will not alter performance

Comparing duration (b20cb98) with duration (a79830e)

Summary

✅ 37 untouched benchmarks

Copy link

codecov bot commented Jun 14, 2024

Codecov Report

Attention: Patch coverage is 72.26891% with 33 lines in your changes missing coverage. Please review.

Project coverage is 80.98%. Comparing base (d00ed0c) to head (b20cb98).
Report is 1 commits behind head on main.

Files Patch % Lines
...s/polars-core/src/series/implementations/floats.rs 50.00% 10 Missing ⚠️
...ates/polars-core/src/series/implementations/mod.rs 50.00% 10 Missing ⚠️
...polars-core/src/series/implementations/duration.rs 89.18% 4 Missing ⚠️
...rates/polars-plan/src/logical_plan/aexpr/schema.rs 71.42% 4 Missing ⚠️
...ates/polars-core/src/series/arithmetic/borrowed.rs 77.77% 2 Missing ⚠️
...rc/logical_plan/conversion/type_coercion/binary.rs 83.33% 2 Missing ⚠️
crates/polars-expr/src/expressions/binary.rs 85.71% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #16948   +/-   ##
=======================================
  Coverage   80.97%   80.98%           
=======================================
  Files        1445     1445           
  Lines      189825   189892   +67     
  Branches     2712     2712           
=======================================
+ Hits       153717   153781   +64     
- Misses      35608    35611    +3     
  Partials      500      500           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit d8e4a61 into main Jun 14, 2024
25 checks passed
@ritchie46 ritchie46 deleted the duration branch June 14, 2024 08:53
Wouittone pushed a commit to Wouittone/polars that referenced this pull request Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PanicException with empty DataFrame when temporal column is used with another method and over
1 participant