Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Raise on invalid temporal arithmetic #16934

Merged
merged 3 commits into from
Jun 13, 2024
Merged

feat: Raise on invalid temporal arithmetic #16934

merged 3 commits into from
Jun 13, 2024

Conversation

ritchie46
Copy link
Member

No description provided.

@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars labels Jun 13, 2024
Copy link

codspeed-hq bot commented Jun 13, 2024

CodSpeed Performance Report

Merging #16934 will not alter performance

Comparing dtypes (119c42f) with main (5bb28b4)

Summary

✅ 37 untouched benchmarks

Copy link

codecov bot commented Jun 13, 2024

Codecov Report

Attention: Patch coverage is 52.17391% with 11 lines in your changes missing coverage. Please review.

Project coverage is 81.09%. Comparing base (5bb28b4) to head (119c42f).

Files Patch % Lines
...rates/polars-plan/src/logical_plan/aexpr/schema.rs 52.17% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16934      +/-   ##
==========================================
- Coverage   81.09%   81.09%   -0.01%     
==========================================
  Files        1435     1435              
  Lines      189567   189579      +12     
  Branches     2712     2712              
==========================================
+ Hits       153736   153737       +1     
- Misses      35331    35342      +11     
  Partials      500      500              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 4584b45 into main Jun 13, 2024
26 checks passed
@ritchie46 ritchie46 deleted the dtypes branch June 13, 2024 18:09
@c-peters c-peters added the accepted Ready for implementation label Jun 16, 2024
Wouittone pushed a commit to Wouittone/polars that referenced this pull request Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants