Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Always end with a in-memory sink on collect #16928

Merged
merged 1 commit into from
Jun 13, 2024
Merged

feat: Always end with a in-memory sink on collect #16928

merged 1 commit into from
Jun 13, 2024

Conversation

ritchie46
Copy link
Member

No description provided.

@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars labels Jun 13, 2024
Copy link

codspeed-hq bot commented Jun 13, 2024

CodSpeed Performance Report

Merging #16928 will degrade performances by 21.14%

Comparing sink (2e81070) with main (9914d96)

Summary

❌ 1 regressions
✅ 36 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main sink Change
test_groupby_h2oai_q3 2.4 ms 3.1 ms -21.14%

Copy link

codecov bot commented Jun 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.10%. Comparing base (9914d96) to head (2e81070).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16928      +/-   ##
==========================================
- Coverage   81.10%   81.10%   -0.01%     
==========================================
  Files        1435     1435              
  Lines      189555   189560       +5     
  Branches     2712     2712              
==========================================
+ Hits       153734   153738       +4     
- Misses      35321    35322       +1     
  Partials      500      500              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit dc4905d into main Jun 13, 2024
22 checks passed
@ritchie46 ritchie46 deleted the sink branch June 13, 2024 12:59
@c-peters c-peters added the accepted Ready for implementation label Jun 16, 2024
Wouittone pushed a commit to Wouittone/polars that referenced this pull request Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants