Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Use split_at in split #16865

Merged
merged 1 commit into from
Jun 11, 2024
Merged

perf: Use split_at in split #16865

merged 1 commit into from
Jun 11, 2024

Conversation

ritchie46
Copy link
Member

This will save a lot of double null_counts.

@github-actions github-actions bot added performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars labels Jun 11, 2024
Copy link

codecov bot commented Jun 11, 2024

Codecov Report

Attention: Patch coverage is 95.65217% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.41%. Comparing base (13d68ae) to head (9a05fc7).

Files Patch % Lines
crates/polars-core/src/utils/mod.rs 95.65% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16865      +/-   ##
==========================================
+ Coverage   81.36%   81.41%   +0.05%     
==========================================
  Files        1425     1425              
  Lines      187910   187926      +16     
  Branches     2705     2705              
==========================================
+ Hits       152885   152995     +110     
+ Misses      34529    34435      -94     
  Partials      496      496              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 84e2ea4 into main Jun 11, 2024
22 checks passed
@ritchie46 ritchie46 deleted the split_at branch June 11, 2024 07:49
@c-peters c-peters added the accepted Ready for implementation label Jun 16, 2024
Wouittone pushed a commit to Wouittone/polars that referenced this pull request Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants