Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Add dedicated no-null branch in arg_sort #16808

Merged
merged 2 commits into from
Jun 7, 2024
Merged

perf: Add dedicated no-null branch in arg_sort #16808

merged 2 commits into from
Jun 7, 2024

Conversation

ritchie46
Copy link
Member

Slightly less work by adding a non-null branch. Will follow up with a proper speed up and special implementation for view types and binaryoffset (row encoding).

@github-actions github-actions bot added performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars labels Jun 7, 2024
Copy link

codspeed-hq bot commented Jun 7, 2024

CodSpeed Performance Report

Merging #16808 will not alter performance

Comparing sort (2b185c6) with main (a0a577a)

Summary

✅ 37 untouched benchmarks

Copy link

codecov bot commented Jun 7, 2024

Codecov Report

Attention: Patch coverage is 93.06931% with 7 lines in your changes missing coverage. Please review.

Project coverage is 81.39%. Comparing base (a0a577a) to head (2b185c6).
Report is 1 commits behind head on main.

Files Patch % Lines
...ates/polars-core/src/chunked_array/ops/sort/mod.rs 88.52% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16808      +/-   ##
==========================================
+ Coverage   81.37%   81.39%   +0.01%     
==========================================
  Files        1424     1424              
  Lines      187554   187579      +25     
  Branches     2697     2697              
==========================================
+ Hits       152622   152672      +50     
+ Misses      34435    34410      -25     
  Partials      497      497              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 1dce3f4 into main Jun 7, 2024
26 checks passed
@ritchie46 ritchie46 deleted the sort branch June 7, 2024 20:41
@c-peters c-peters added the accepted Ready for implementation label Jun 9, 2024
@stinodego stinodego changed the title perf: Special no null branch in arg-sort perf: Add dedicated no-null branch in arg_sort Jun 9, 2024
Wouittone pushed a commit to Wouittone/polars that referenced this pull request Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants