feat(python)!: Constrain access to globals from DataFrame.sql
in favor of top-level pl.sql
#16598
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed; updates
df.sql(query)
such that it can only access "self", deferring topl.sql(query)
when access to frames in the current stack is required.This better-distinguishes the purpose of each function and allows for frame-level
df.sql
to be marginally optimised (as there is no longer any need to introspect globals).Example
Before:
After:
>>> df1.sql("SELECT * FROM df1 CROSS JOIN df2") Traceback (most recent call last): ... polars.exceptions.SQLInterfaceError: relation 'df1' was not found
Use instead: