Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unnecessary unsafe in list mean/sum #15660

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

orlp
Copy link
Collaborator

@orlp orlp commented Apr 15, 2024

No description provided.

@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars labels Apr 15, 2024
@reswqa
Copy link
Collaborator

reswqa commented Apr 15, 2024

Much cleaner! 👍

Copy link

codecov bot commented Apr 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.30%. Comparing base (99ab9c0) to head (356a522).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15660      +/-   ##
==========================================
- Coverage   81.31%   81.30%   -0.01%     
==========================================
  Files        1373     1373              
  Lines      176254   176253       -1     
  Branches     2544     2544              
==========================================
- Hits       143320   143308      -12     
- Misses      32452    32463      +11     
  Partials      482      482              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Apr 15, 2024

CodSpeed Performance Report

Merging #15660 will improve performances by 10.24%

Comparing orlp:unsafe-mean-chore (356a522) with main (4e17d02)

Summary

⚡ 1 improvements
✅ 21 untouched benchmarks

Benchmarks breakdown

Benchmark main orlp:unsafe-mean-chore Change
test_windows_not_cached 3.5 s 3.2 s +10.24%

@ritchie46 ritchie46 merged commit b5b64c1 into pola-rs:main Apr 15, 2024
20 checks passed
@c-peters c-peters added the accepted Ready for implementation label Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants