Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(rust!): rename memmap -> memory_map as like Python #15642

Merged
merged 1 commit into from
Apr 14, 2024

Conversation

eitsupi
Copy link
Contributor

@eitsupi eitsupi commented Apr 14, 2024

When reading an Arrow IPC file, the following warning message may appear, but it may be unclear what it means because the Rust API uses memmap instead of memory_map.

Toggle off 'memory_map' to silence this warning."

This PR updates memmap arguments to memory_map

@github-actions github-actions bot added breaking rust Change that breaks backwards compatibility for the Rust crate internal An internal refactor or improvement rust Related to Rust Polars labels Apr 14, 2024
Copy link

codecov bot commented Apr 14, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 81.30%. Comparing base (7341aee) to head (963e01c).

❗ Current head 963e01c differs from pull request most recent head 7b8c83e. Consider uploading reports for the commit 7b8c83e to get more accurate results

Files Patch % Lines
crates/polars-io/src/ipc/ipc_file.rs 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15642      +/-   ##
==========================================
- Coverage   81.30%   81.30%   -0.01%     
==========================================
  Files        1373     1373              
  Lines      176243   176243              
  Branches     2544     2544              
==========================================
- Hits       143293   143286       -7     
- Misses      32466    32475       +9     
+ Partials      484      482       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Apr 14, 2024

CodSpeed Performance Report

Merging #15642 will degrade performances by 11.74%

Comparing eitsupi:memory_map-in-rust (7b8c83e) with main (4eef5b5)

Summary

❌ 1 regressions
✅ 21 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main eitsupi:memory_map-in-rust Change
test_sort_nan_1942 1 ms 1.2 ms -11.74%

@eitsupi

This comment was marked as outdated.

@ritchie46 ritchie46 merged commit 81002ca into pola-rs:main Apr 14, 2024
23 checks passed
@eitsupi eitsupi deleted the memory_map-in-rust branch April 14, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking rust Change that breaks backwards compatibility for the Rust crate internal An internal refactor or improvement rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants