chore: fixup failing test due to offset deprecation in upsample
#15636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
internal
MarcoGorelli
commented
Apr 13, 2024
| ), | ||
| ], | ||
| ) | ||
| def test_upsample_index_invalid( | ||
| df: pl.DataFrame, | ||
| every: str, | ||
| offset: str, | ||
| fill: FillNullStrategy | None, |
There was a problem hiding this comment.
drive-by, but fill is unused in this function
MarcoGorelli
force-pushed
the
ci-deprecated-offset
branch
from
a85347d
to
3fd630d
Compare
MarcoGorelli
changed the title
offset deprecation in upsample
MarcoGorelli
requested review from
ritchie46,
stinodego,
c-peters,
alexander-beedie and
reswqa
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two tests were failing due to this
I've removed
offsetfrom one (upsampling by integers, which is a new functionality anyway), and am catching the deprecation warning in the other