fix: Fix issue in write_excel that could lead to incorrect spanning range determination
#15631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-beedie
requested review from
ritchie46,
stinodego,
c-peters,
MarcoGorelli and
reswqa
as code owners
github-actions
bot
added
fix
alexander-beedie
changed the title
write_excel that could lead to incorrect spanning range determinationwrite_excel that could lead to incorrect spanning range determination
…ad to incorrect spanning range determination
alexander-beedie
force-pushed
the
write-excel-multi-range-fix
branch
from
392dba4
to
ac8a02e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15631 +/- ##
==========================================
- Coverage 81.25% 81.25% -0.01%
==========================================
Files 1371 1371
Lines 175808 175808
Branches 2543 2543
==========================================
- Hits 142856 142853 -3
- Misses 32469 32472 +3
Partials 483 483 ☔ View full report in Codecov by Sentry. |
ritchie46
approved these changes
Apr 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15629.
Fixes an operator precedence gremlin.