Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use bound api #15630

Merged
merged 1 commit into from
Apr 13, 2024
Merged

chore: use bound api #15630

merged 1 commit into from
Apr 13, 2024

Conversation

ritchie46
Copy link
Member

No description provided.

@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars labels Apr 13, 2024
@ritchie46 ritchie46 merged commit be29982 into main Apr 13, 2024
18 of 19 checks passed
@ritchie46 ritchie46 deleted the bound branch April 13, 2024 12:01
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Apr 13, 2024

CodSpeed Performance Report

Merging #15630 will degrade performances by 10.36%

Comparing bound (6867729) with main (92902e6)

Summary

❌ 1 regressions
✅ 21 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main bound Change
❌ test_sort_nan_1942 1 ms 1.2 ms -10.36%

@c-peters c-peters added the accepted Ready for implementation label Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stinodego stinodego Awaiting requested review from stinodego

@orlp orlp Awaiting requested review from orlp orlp is a code owner

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

Assignees

@ritchie46 ritchie46

Labels
accepted Ready for implementation internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars
Projects
Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ritchie46 @c-peters