Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Fix binview growable complexity O(n*m) -> O(n) #15628

Merged
merged 1 commit into from
Apr 13, 2024
Merged

Conversation

ritchie46
Copy link
Member

fixes #15615

@github-actions github-actions bot added performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars labels Apr 13, 2024
Copy link

codecov bot commented Apr 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.26%. Comparing base (b09a709) to head (abdd60c).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #15628   +/-   ##
=======================================
  Coverage   81.26%   81.26%           
=======================================
  Files        1371     1371           
  Lines      175779   175775    -4     
  Branches     2531     2531           
=======================================
  Hits       142839   142839           
+ Misses      32464    32460    -4     
  Partials      476      476           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Apr 13, 2024

CodSpeed Performance Report

Merging #15628 will not alter performance

Comparing binview (abdd60c) with main (92902e6)

Summary

✅ 22 untouched benchmarks

@ritchie46 ritchie46 merged commit f8764c0 into main Apr 13, 2024
20 checks passed
@ritchie46 ritchie46 deleted the binview branch April 13, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Performance issues or improvements python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Grouping to list of struct is slower in 0.20.6 than in 0.20.5 and leads to out-of-memory eventually
1 participant