-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add holidays argument to business_day_count #15580
Conversation
ad0d101
to
6013990
Compare
6013990
to
4b5d9b4
Compare
CodSpeed Performance ReportMerging #15580 will improve performances by 22.86%Comparing Summary
Benchmarks breakdown
|
let mut holidays: Vec<i32> = holidays | ||
.iter() | ||
.filter(|&x| *unsafe { week_mask.get_unchecked(weekday(*x)) }) | ||
.cloned() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be copied?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15580 +/- ##
==========================================
+ Coverage 81.11% 81.12% +0.01%
==========================================
Files 1367 1367
Lines 174934 174981 +47
Branches 2530 2531 +1
==========================================
+ Hits 141890 141946 +56
+ Misses 32569 32559 -10
- Partials 475 476 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left one comment on the unsafe
tag. After that it is good to go. :)
thanks for your review! 🙏 |
Business polars: part 3 of 5
Is there a better way to pass the list of holidays on from Python to Rust?