refactor(rust!): Update the argument name from dims
to dimensions
in reshape
#15561
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #8017, the
reshape
's argument name changed only on the Python side, so it no longer matches in Rust and in Python.In #12288, update the error message from
reshape
in Rust, but used the Python argument name, making it difficult to understand. (It saysreshape `dimensions` cannot be empty
, but the real argument name isdims
, notdimensions
)So I think it's worth unifying the argument names.