Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(rust!): Update the argument name from dims to dimensions in reshape #15561

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

eitsupi
Copy link
Contributor

@eitsupi eitsupi commented Apr 9, 2024

In #8017, the reshape's argument name changed only on the Python side, so it no longer matches in Rust and in Python.

In #12288, update the error message from reshape in Rust, but used the Python argument name, making it difficult to understand. (It says reshape `dimensions` cannot be empty, but the real argument name is dims, not dimensions)
So I think it's worth unifying the argument names.

@github-actions github-actions bot added the internal An internal refactor or improvement label Apr 9, 2024
Copy link

codspeed-hq bot commented Apr 9, 2024

CodSpeed Performance Report

Merging #15561 will not alter performance

Comparing eitsupi:update-reshape-arg-name (08a44e0) with main (42d3697)

Summary

✅ 22 untouched benchmarks

Copy link

codecov bot commented Apr 9, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 81.17%. Comparing base (0a33859) to head (08a44e0).

Files Patch % Lines
crates/polars-core/src/series/ops/to_list.rs 84.61% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15561      +/-   ##
==========================================
+ Coverage   81.15%   81.17%   +0.02%     
==========================================
  Files        1367     1367              
  Lines      175313   175313              
  Branches     2530     2530              
==========================================
+ Hits       142269   142308      +39     
+ Misses      32566    32530      -36     
+ Partials      478      475       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit b91dedb into pola-rs:main Apr 9, 2024
21 checks passed
@eitsupi eitsupi deleted the update-reshape-arg-name branch April 9, 2024 21:41
@stinodego stinodego changed the title refactor!(rust): update the argument name from dims to dimensions in reshape refactor(rust!): update the argument name from dims to dimensions in reshape Apr 10, 2024
@stinodego stinodego changed the title refactor(rust!): update the argument name from dims to dimensions in reshape refactor(rust!): Update the argument name from dims to dimensions in reshape Apr 10, 2024
@github-actions github-actions bot added breaking rust Change that breaks backwards compatibility for the Rust crate rust Related to Rust Polars labels Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking rust Change that breaks backwards compatibility for the Rust crate internal An internal refactor or improvement rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants