Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enable is_first/last_distinct for not nested non-numeric list #15552

Merged
merged 2 commits into from
Apr 10, 2024

Conversation

reswqa
Copy link
Collaborator

@reswqa reswqa commented Apr 9, 2024

Since we have shift to row-encode for group-by list. I think we could get rid of the limitation for is_first/last_distinct also.

@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars labels Apr 9, 2024
@reswqa reswqa marked this pull request as ready for review April 9, 2024 07:20
Copy link

codspeed-hq bot commented Apr 9, 2024

CodSpeed Performance Report

Merging #15552 will not alter performance

Comparing reswqa:list_first_last (4d55d5c) with main (44f1097)

Summary

✅ 22 untouched benchmarks

Copy link

codecov bot commented Apr 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.17%. Comparing base (44f1097) to head (4d55d5c).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #15552   +/-   ##
=======================================
  Coverage   81.16%   81.17%           
=======================================
  Files        1367     1367           
  Lines      175307   175322   +15     
  Branches     2527     2530    +3     
=======================================
+ Hits       142296   142321   +25     
+ Misses      32534    32525    -9     
+ Partials      477      476    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit dc415b0 into pola-rs:main Apr 10, 2024
24 checks passed
@reswqa reswqa deleted the list_first_last branch April 10, 2024 06:02
mbuhidar pushed a commit to mbuhidar/polars that referenced this pull request Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants