Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(python): Pass skip_rows_after_header to pyarrow csv reader #15533

Merged
merged 2 commits into from
Apr 8, 2024

Conversation

reswqa
Copy link
Collaborator

@reswqa reswqa commented Apr 8, 2024

This fixes #15497.

@github-actions github-actions bot added fix Bug fix python Related to Python Polars labels Apr 8, 2024
Copy link

codecov bot commented Apr 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.13%. Comparing base (cc6c642) to head (23e10b4).
Report is 13 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15533      +/-   ##
==========================================
- Coverage   81.14%   81.13%   -0.02%     
==========================================
  Files        1362     1363       +1     
  Lines      174989   175161     +172     
  Branches     2533     2527       -6     
==========================================
+ Hits       142000   142110     +110     
- Misses      32505    32573      +68     
+ Partials      484      478       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reswqa reswqa marked this pull request as ready for review April 8, 2024 08:07
Copy link
Collaborator

@alexander-beedie alexander-beedie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah; I think the unit test needs to check both cases? (eg: use_pyarrow = True/False; the issue mentions True, but the test checks False). The fix itself looks good though 👍

@reswqa
Copy link
Collaborator Author

reswqa commented Apr 8, 2024

Oops, I want to check the pyarrow = True indeed, good catch! But it's better to test both, updated 😉

@alexander-beedie
Copy link
Collaborator

Oops, I want to check the pyarrow = True indeed, good catch! But it's better to test both, updated 😉

Perfect; will merge when CI goes green :)

@alexander-beedie alexander-beedie merged commit c211fad into pola-rs:main Apr 8, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

read_csv ignores skip_rows_after_header when use_pyarrow=True
2 participants