perf: speed up offset_by when a single offset is passed #15493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
performance
MarcoGorelli
changed the title
MarcoGorelli
force-pushed
the
perf-offset-by
branch
from
1b8c964
to
d0df3de
Compare
MarcoGorelli
requested review from
ritchie46,
stinodego,
orlp and
c-peters
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15493 +/- ##
=======================================
Coverage 81.14% 81.14%
=======================================
Files 1362 1362
Lines 174951 174953 +2
Branches 2533 2533
=======================================
+ Hits 141960 141973 +13
+ Misses 32508 32496 -12
- Partials 483 484 +1 ☔ View full report in Codecov by Sentry. |
ritchie46
approved these changes
Apr 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #15482
this is my fault, from a commit I'd added to: https://github.com/pola-rs/polars/pull/9967/files 😳 🤦