feat: Implements agg_list for NullChunked
#15439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
enhancement
reswqa
commented
Apr 2, 2024
| @@ -183,6 +188,10 @@ impl SeriesTrait for NullChunked { | |||
| NullChunked::new(self.name.clone(), self.len()).into_series() | |||
| } | |||
|
|
|||
| fn drop_nulls(&self) -> Series { | |||
| NullChunked::new(self.name.clone(), 0).into_series() | |||
There was a problem hiding this comment.
Not much, but it should be better than the default implementation.
reswqa
requested review from
ritchie46,
stinodego,
c-peters,
alexander-beedie,
MarcoGorelli and
orlp
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15439 +/- ##
=======================================
Coverage 81.13% 81.13%
=======================================
Files 1362 1362
Lines 174820 174846 +26
Branches 2531 2531
=======================================
+ Hits 141836 141865 +29
+ Misses 32500 32497 -3
Partials 484 484 ☔ View full report in Codecov by Sentry. |
ritchie46
approved these changes
Apr 2, 2024
| @@ -183,6 +188,10 @@ impl SeriesTrait for NullChunked { | |||
| NullChunked::new(self.name.clone(), self.len()).into_series() | |||
| } | |||
|
|
|||
| fn drop_nulls(&self) -> Series { | |||
| NullChunked::new(self.name.clone(), 0).into_series() | |||
nameexhaustion
pushed a commit
to nameexhaustion/polars
that referenced
this pull request
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We must implements
agg_listforNullChunked, otherwise it will be dispatched to the default implementation which doesn't produce a list series.This fixes #15437.