feat(python): make Series.__bool__ error message Rusttier #15407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
enhancement
MarcoGorelli
force-pushed
the
bool-err-msg
branch
from
ab518fb
to
4a1457d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15407 +/- ##
==========================================
- Coverage 81.41% 81.12% -0.30%
==========================================
Files 1362 1361 -1
Lines 176520 174599 -1921
Branches 2531 2531
==========================================
- Hits 143713 141642 -2071
- Misses 32322 32472 +150
Partials 485 485 ☔ View full report in Codecov by Sentry. |
Makes sense to me ☝️ |
MarcoGorelli
requested review from
ritchie46,
stinodego,
c-peters,
alexander-beedie and
reswqa
as code owners
ritchie46
approved these changes
Mar 31, 2024
|
Always love more rusty error messages. 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expr.__bool__got a lot of love on Discord:Might be good to do the same for
Series.__bool__?