refactor: make dsl immutable and cheap to clone #15394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orlp
requested review from
ritchie46,
stinodego,
c-peters,
universalmind303 and
alexander-beedie
as code owners
github-actions
bot
added
internal
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15394 +/- ##
==========================================
- Coverage 81.26% 81.25% -0.02%
==========================================
Files 1361 1361
Lines 174713 174731 +18
Branches 2531 2531
==========================================
- Hits 141989 141972 -17
- Misses 32240 32273 +33
- Partials 484 486 +2 ☔ View full report in Codecov by Sentry. |
ritchie46
approved these changes
Mar 30, 2024
| Arc::make_mut(&mut arc); | ||
|
|
||
| // If f panics we must be able to drop the Arc without assuming it is initialized. | ||
| let mut uninit_arc = Arc::from_raw(Arc::into_raw(arc).cast::<MaybeUninit<T>>()); |
There was a problem hiding this comment.
Does panicking change the repr of T?
There was a problem hiding this comment.
@ritchie46 When an Arc gets dropped due to the panic unwinding it drops the value inside the arc (if it was the last reference). But since we temporarily take out the value using ptr::read that would be invalid and could lead to double drops. So we change toMaybeUninit temporarily which has a no-op drop for the value inside the Arc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.