fix(python): Propagate strictness in from_dicts
#15344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stinodego
requested review from
ritchie46,
c-peters,
alexander-beedie and
MarcoGorelli
as code owners
stinodego
commented
Mar 27, 2024
| let val = match d.get_item(k)? { | ||
| None => AnyValue::Null, | ||
| Some(val) => val.extract::<Wrap<AnyValue>>()?.0, | ||
| Some(val) => py_object_to_any_value(val, strict)?, |
There was a problem hiding this comment.
This was the key to the issue - calling extract on Wrap<AnyValue> defaults to strict.
|
Hello, it doesn't seem to have fully fixed this problem, I still get errors either with PyDataFrame.from_dict or PyDataFrame.from_rows. |
|
To be complete it does not throw the same error than with strict = True (in column orientation) but a more cryptic could not append value: "" of type: str to the builder; make sure that all rows have the same schema or consider increasing `infer_schema_length` |
|
@ruomad Could you give a code example? |
pl.DataFrame([{'a': 1.0, 'b': ''}], schema = {'a': pl.Float64, 'b': pl.Float64}, orient = 'row', strict = False)
pl.DataFrame([[1.0, '']], schema = {'a': pl.Float64, 'b': pl.Float64}, orient = 'row', strict = False)
both yield : polars.exceptions.ComputeError: could not append value: "" of type: str to the builder; make sure that all rows have the same schema or consider increasing `infer_schema_length` |
|
@ruomad right, so this has to do with empty strings probably. Could you open an issue and tag me please? |
|
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15245
Includes some minor refactoring.