Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implements arr.n_unique #15296

Merged
merged 1 commit into from
Mar 28, 2024
Merged

feat: Implements arr.n_unique #15296

merged 1 commit into from
Mar 28, 2024

Conversation

reswqa
Copy link
Collaborator

@reswqa reswqa commented Mar 26, 2024

Counterpart of list.n_unique in array namespace. This closes #14273.

(After a busy period, finally had time to play with polars 😉)

@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars labels Mar 26, 2024
@reswqa reswqa marked this pull request as draft March 26, 2024 07:52
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

Attention: Patch coverage is 96.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 81.35%. Comparing base (705b148) to head (b86789a).
Report is 2 commits behind head on main.

Files Patch % Lines
crates/polars-plan/src/dsl/function_expr/array.rs 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15296      +/-   ##
==========================================
+ Coverage   81.32%   81.35%   +0.03%     
==========================================
  Files        1360     1364       +4     
  Lines      176070   176596     +526     
  Branches     2526     2526              
==========================================
+ Hits       143183   143670     +487     
- Misses      32403    32443      +40     
+ Partials      484      483       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reswqa reswqa marked this pull request as ready for review March 26, 2024 08:27
Copy link
Member

@ritchie46 ritchie46 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to see you again on the PR board!

@ritchie46 ritchie46 merged commit e1bba07 into pola-rs:main Mar 28, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

implement n_unique in list/array namespace
2 participants