-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(python): Improve read_database
when reading from Kùzu graph database
#15218
Conversation
kuzu
graph databasekuzu
graph database
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Just some very minor remarks.
0632522
to
a1c656a
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15218 +/- ##
==========================================
+ Coverage 81.25% 81.26% +0.01%
==========================================
Files 1354 1355 +1
Lines 175631 175657 +26
Branches 2518 2522 +4
==========================================
+ Hits 142702 142743 +41
+ Misses 32448 32431 -17
- Partials 481 483 +2 ☔ View full report in Codecov by Sentry. |
a1c656a
to
81a59a7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Nice to have the minimum version too.
kuzu
graph databaseread_database
when reading from Kùzu graph database
Can directly use
get_as_pl()
now; requires a new version ofkuzu
, but this seems reasonable. Added an optional "minimum_version" module/driver check to gracefully handle this - raises aModuleUpgradeRequired
exception if an insufficiently recent version is found.Note that the next release of
kuzu
will also include an improvement1 in Arrow chunking insideget_as_pl()
, meaning we'll no longer need to rechunk (will always get a single chunk from now on).Footnotes
https://github.com/kuzudb/kuzu/pull/3110 ↩