Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Run non-benchmark tests in benchmark workflow #15207

Merged
merged 3 commits into from
Mar 21, 2024
Merged

ci: Run non-benchmark tests in benchmark workflow #15207

merged 3 commits into from
Mar 21, 2024

Conversation

stinodego
Copy link
Member

@stinodego stinodego commented Mar 21, 2024

Since we're building the release binary anyway, might as well run the other tests to make sure they also pass on a release build.

Changes

  • Rename pytest marker benchmark to release
  • Add new pytest marker debug. This marker is used for tests that rely on debug assertions to work.
  • Add step to run non-release and non-debug tests in the benchmark workflow.

@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars labels Mar 21, 2024
@stinodego stinodego force-pushed the ci-bench branch 2 times, most recently from e5ab677 to 4077ba9 Compare March 21, 2024 13:12
Copy link

codecov bot commented Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.23%. Comparing base (2a3b363) to head (0128469).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15207      +/-   ##
==========================================
- Coverage   81.25%   81.23%   -0.02%     
==========================================
  Files        1354     1354              
  Lines      175631   175633       +2     
  Branches     2518     2518              
==========================================
- Hits       142702   142676      -26     
- Misses      32448    32476      +28     
  Partials      481      481              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stinodego
Copy link
Member Author

Test failures unrelated.

@stinodego stinodego merged commit 28414f5 into main Mar 21, 2024
14 of 16 checks passed
@stinodego stinodego deleted the ci-bench branch March 21, 2024 15:31
@c-peters c-peters added the accepted Ready for implementation label Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants