docs(python): Add a note about the behaviour of lower/upper bounds for is_between, and add an example
#15197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-beedie
requested review from
ritchie46,
stinodego,
c-peters and
MarcoGorelli
as code owners
github-actions
bot
added
documentation
…r `is_between`, and add an example
alexander-beedie
force-pushed
the
isbetween-example-and-docstring-note
branch
from
1de4791
to
c084e6a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15197 +/- ##
==========================================
- Coverage 81.22% 81.22% -0.01%
==========================================
Files 1348 1348
Lines 175333 175333
Branches 2508 2508
==========================================
- Hits 142420 142409 -11
- Misses 32433 32444 +11
Partials 480 480 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15185.
Our
is_betweenfunctionality is correct, and consistent with other implementations (see the equivalentBETWEENkeyword in SQL1 for an example of this), but we can better document the behaviour whenlower_bound > upper_bound.Footnotes
https://www.postgresql.org/docs/current/functions-comparison.html#FUNCTIONS-COMPARISON-PRED-TABLE ↩